Properly handle conditional expression within parens as RHS of assignment #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1140 +/- ##
=========================================
Coverage 88.24% 88.24%
- Complexity 2260 2261 +1
=========================================
Files 85 85
Lines 7305 7309 +4
Branches 1457 1458 +1
=========================================
+ Hits 6446 6450 +4
Misses 431 431
Partials 428 428 ☔ View full report in Codecov by Sentry. |
akshayutture
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1127
Our previous (hacky) logic for determining the type of a conditional expression on the RHS of an assignment did not account for the expression possibly being enclosed in parentheses.