Update the test actions runner to run on supported Node releases #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfellis
commented
Jan 29, 2025
| @@ -45,7 +45,7 @@ | |||
| "rollup-bindings": "rollup build/print-bindings.js --file dist/print-bindings.js --format cjs", | |||
| "rollup-benchmark-browser": "rollup benchmark/browser.js --file dist/benchmark.browser.js --format=umd --external=benchmark --globals=benchmark:Benchmark", | |||
| "rollup-benchmark-node": "rollup benchmark/node.js --file dist/benchmark.node.js --format=cjs --external=benchmark", | |||
| "docker-boot": "docker run -dit --name emscripten -v $(pwd):/src trzeci/emscripten:sdk-tag-1.38.43-64bit bash", | |||
| "docker-boot": "docker run -dit --name emscripten -v $(pwd):/src:Z trzeci/emscripten:sdk-tag-1.38.43-64bit bash", | |||
There was a problem hiding this comment.
This change is only necessary for Fedora and the few other Linux distros that use SELinux. It shouldn't cause a problem otherwise, though, I believe?
dfellis
commented
Jan 29, 2025
| @@ -71,6 +71,7 @@ | |||
| "./dist/h3-js.es.js": "./dist/browser/h3-js.es.js" | |||
| }, | |||
| "devDependencies": { | |||
| "@types/markdown-it": "14.1.2", | |||
There was a problem hiding this comment.
I had to force this to the latest version to fix the test suite, because typescript was failing to compile after doing a yarn upgrade. I'm not sure why yarn didn't upgrade this dependency automatically.
Pull Request Test Coverage Report for Build 13038317214Details
💛 - Coveralls |
isaacbrodsky
approved these changes
Jan 29, 2025
nrabinowitz
approved these changes
Jan 31, 2025
| @@ -15,18 +15,18 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node_version: [6, 8, 10, 14] | |||
There was a problem hiding this comment.
Wow, sorry Node 6 users 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this locally only with Node 18. I could have manually tested later versions but I figure this will be faster.
Resolves #199