Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly state parameters are (void), #787 #788

Merged
merged 3 commits into from
Oct 16, 2023
Merged

explicitly state parameters are (void), #787 #788

merged 3 commits into from
Oct 16, 2023

Conversation

isaacbrodsky
Copy link
Collaborator

Fixes #787.

@isaacbrodsky isaacbrodsky changed the title explicitly state parameters are , #787 explicitly state parameters are (void), #787 Oct 10, 2023
@isaacbrodsky isaacbrodsky mentioned this pull request Oct 10, 2023
Closed
@dcooley
Copy link

dcooley commented Oct 11, 2023

is it also required in iterators.c L45?

static IterCellsChildren _null_iter(void)

@isaacbrodsky isaacbrodsky merged commit a8f2a8a into uber:master Oct 16, 2023
31 checks passed
@isaacbrodsky isaacbrodsky deleted the void-parameters branch October 16, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfellis dfellis dfellis approved these changes

@nrabinowitz nrabinowitz nrabinowitz approved these changes

@ajfriend ajfriend Awaiting requested review from ajfriend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace empty function parameters with void
4 participants
@isaacbrodsky @dcooley @nrabinowitz @dfellis