Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case where parent bounding box contains hole #806

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

nrabinowitz
Copy link
Collaborator

This issue came up when comparing old/new output for countries: When the parent bounding box is fully contained by the outer polygon but fully contains a hole, we were still including the parent in the output. The fix is to check whether the bounding box contains a vertex of the hole, and fail fast if it does.

@coveralls
Copy link

Coverage Status

coverage: 98.824% (+0.002%) from 98.822%
when pulling be92c3b on nrabinowitz:hole-fix
into a61a464 on uber:master.

@nrabinowitz nrabinowitz merged commit c3c6f7a into uber:master Dec 14, 2023
33 checks passed
@nrabinowitz nrabinowitz deleted the hole-fix branch December 14, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants