Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tbbuck/H3.net.SqlClr to bindings list for SQL Server #822

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

tbbuck
Copy link
Contributor

@tbbuck tbbuck commented Mar 19, 2024

Adding SQL CLR implementation of H3 for SQL Server using the https://github.com/pocketken/H3.net C# port as a base.

Adding SQL CLR implementation of H3 for SQL Server using the https://github.com/pocketken/H3.net C# port as a base.
@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024

CLA assistant check
All committers have signed the CLA.

Comment on lines 114 to 117
## SQL Server

- [tbbuck/H3.net.SqlClr](https://github.com/tbbuck/H3.net.SqlClr)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be added after SQLite, below, to keep things in alphabetical order

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I'm quite impressed my alphabetical skills failed me there 🤦‍♀️ Good call, updated!

@coveralls
Copy link

coveralls commented Mar 20, 2024

Coverage Status

coverage: 98.827%. remained the same
when pulling da09b8e on tbbuck:patch-1
into d00624c on uber:master.

Copy link
Collaborator

@isaacbrodsky isaacbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding. I believe the CI changes are unrelated to this and are something I will look into further.

@isaacbrodsky
Copy link
Collaborator

Looks good, thanks for adding. I believe the CI changes are unrelated to this and are something I will look into further.

Oh, apparently the CI is working now. I don't know what changed, but maybe something in Github Actions got fixed. Thanks again for the PR!

@isaacbrodsky isaacbrodsky merged commit a528375 into uber:master Mar 20, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants