Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix 871 #872

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

swotai
Copy link
Collaborator

@swotai swotai commented Jul 8, 2024

Description

Adjust the is_ordered_datetime helper function to take care of both tz and non-tz arrays

Fixes #871

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix

To allow is_ordered_datetime() to handle tz-aware vectors, use pandas.to_series().diff()
@swotai swotai requested a review from edwinnglabs July 8, 2024 06:20
@swotai swotai linked an issue Jul 8, 2024 that may be closed by this pull request
@edwinnglabs edwinnglabs merged commit cde4167 into dev Jul 9, 2024
4 checks passed
@edwinnglabs edwinnglabs deleted the 871-fit-method-fail-for-timezone-aware-timeseries branch July 9, 2024 06:07
@edwinnglabs edwinnglabs restored the 871-fit-method-fail-for-timezone-aware-timeseries branch July 9, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fit method fail for Timezone aware timeseries
2 participants