build.gradle: exclude 'binexport' and '.github' from distribution #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubfx
reviewed
Sep 27, 2024
|
Do you have an idea why building seems to fail with latest ghidra? Does it work locally for you? |
SmileyAG
force-pushed
the
exclude_binexport_from_dist
branch
from
5fd7355 to
a4fc49e
Compare
|
Should be fine now, just needed to rebase from the latest commit of master due to the fixes in #28 pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really don't need to include the binexport source code in the distribution, since it is not used in runtime and only takes up 2/3 of the archive size.