generated from ubiquity/ts-template
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify user on the deadline when assigned manually #12
Comments
@gentlementlegen the deadline is at 2024-08-20T04:57:39.130Z |
Merged
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 50 |
Issue | Specification | 1 | 21.3 |
Review | Comment | 14 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
V1 will notice a user of its deadline when it is assigned throug… | 21.3content: p: symbols: \b\w+\b: count: 66 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 5 multiplier: 3 | 1 | 21.3 |
Resolves #12 Depends on #21, #19 QA: https://github.com/Menio… | 0content: p: symbols: \b\w+\b: count: 18 multiplier: 0 score: 1 ul: symbols: \b\w+\b: count: 45 multiplier: 0 score: 1 li: symbols: \b\w+\b: count: 35 multiplier: 0 score: 1 multiplier: 0 | 0.2 | - |
You should comment on these to the related PR, I did not authore… | 0content: p: symbols: \b\w+\b: count: 23 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
It is arbitrary and not related to HTTP requests, this is just i… | 0content: p: symbols: \b\w+\b: count: 21 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
It contains proxy calls for events. | 0content: p: symbols: \b\w+\b: count: 6 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Referenc… | 0content: p: symbols: \b\w+\b: count: 12 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
That's why I have it as a draft, and in the description I put "D… | 0content: p: symbols: \b\w+\b: count: 39 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Sure a switch can work. Having the proxy enforces implementing a… | 0content: p: symbols: \b\w+\b: count: 20 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
It's not standardized as these types should actually come from t… | 0content: p: symbols: \b\w+\b: count: 27 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
I can make it a switch case, I just think that the more actions … | 0content: p: symbols: \b\w+\b: count: 63 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Good catch, I guess I'll totally skip if no deadline is set. | 0content: p: symbols: \b\w+\b: count: 13 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
New QA: https://github.com/Meniole/command-start-stop/issues/10#… | 0content: p: symbols: \b\w+\b: count: 13 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Is it directly related to this pull-request or not? If so I will… | 0content: p: symbols: \b\w+\b: count: 25 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
@Keyrxng time is given in UTC, so I don't know the time zone you… | 0content: p: symbols: \b\w+\b: count: 68 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
@Keyrxng sure I can check that time issue and add some tests wit… | 0content: p: symbols: \b\w+\b: count: 27 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
[ 55.6 WXDAI ]
@Keyrxng
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Review | Comment | 9 | 55.6 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
There seems to be an issue with posting error comments https://… | 2.1content: p: symbols: \b\w+\b: count: 21 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 2.1 |
I would appreciate comments in this file and I think newer contr… | 3content: p: symbols: \b\w+\b: count: 30 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 3 |
Seems to me the same could be achieved with a `if` or &#… | 2.3content: p: symbols: \b\w+\b: count: 22 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 2.3 |
But all this proxy does is convolute what could be a simple `… | 9.3content: p: symbols: \b\w+\b: count: 92 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 9.3 |
I am not against the Proxy but I think if we are adopting it as … | 11.7content: h2: symbols: \b\w+\b: count: 41 multiplier: 0.1 score: 1 p: symbols: \b\w+\b: count: 73 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 3 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 11.7 |
For some reason this PR is not posting a comment but my PR I jus… | 4.4content: p: symbols: \b\w+\b: count: 41 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 a: symbols: \b\w+\b: count: 2 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 4.4 |
Unsure exactly what's causing it considering the bubble-up logic… | 4.5content: p: symbols: \b\w+\b: count: 45 multiplier: 0.1 score: 1 img: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 0 multiplier: 1 | 1 | 4.5 |
Odd that the Proxy messed with bubbling up the error that's some… | 10.2content: p: symbols: \b\w+\b: count: 79 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 2 multiplier: 0.1 score: 1 h6: symbols: \b\w+\b: count: 8 multiplier: 0.1 score: 1 h2: symbols: \b\w+\b: count: 13 multiplier: 0.1 score: 1 img: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 0 multiplier: 1 | 1 | 10.2 |
That'll be my mistake then my bad. My timezone is UTC+00 which I… | 8.1content: p: symbols: \b\w+\b: count: 80 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 8.1 |
[ 19.8 WXDAI ]
@0x4007
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Review | Comment | 14 | 19.8 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
What is this file? | 0.4content: p: symbols: \b\w+\b: count: 4 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.4 |
```suggestion const log = logger.error("You wer… | 1.7content: pre: symbols: \b\w+\b: count: 17 multiplier: 0.1 score: 0 code: symbols: \b\w+\b: count: 17 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.7 |
```suggestion return { content: "Task assigned su… | 1.9content: pre: symbols: \b\w+\b: count: 7 multiplier: 0.1 score: 0 code: symbols: \b\w+\b: count: 7 multiplier: 0.1 score: 1 p: symbols: \b\w+\b: count: 12 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.9 |
```suggestion return { content: "You are not as… | 1.1content: pre: symbols: \b\w+\b: count: 11 multiplier: 0.1 score: 0 code: symbols: \b\w+\b: count: 11 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.1 |
```suggestion return { content: "Task unassigned … | 0.7content: pre: symbols: \b\w+\b: count: 7 multiplier: 0.1 score: 0 code: symbols: \b\w+\b: count: 7 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.7 |
```suggestion APP_ID: T.Number(), ```… | 1.2content: pre: symbols: \b\w+\b: count: 3 multiplier: 0.1 score: 0 code: symbols: \b\w+\b: count: 3 multiplier: 0.1 score: 1 p: symbols: \b\w+\b: count: 9 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.2 |
Although this doesn't feel like `200` would be the corre… | 2content: p: symbols: \b\w+\b: count: 19 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 2 |
Same here I feel like there might be a more accurate status code… | 1.5content: p: symbols: \b\w+\b: count: 15 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.5 |
What is a "proxy call"? | 0.5content: p: symbols: \b\w+\b: count: 5 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.5 |
It makes sense to follow that standard instead of making our own. | 1.2content: p: symbols: \b\w+\b: count: 12 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.2 |
I am confused because its not included in that pull. Besides, yo… | 2.5content: p: symbols: \b\w+\b: count: 25 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 2.5 |
Yeah I just had a quick tutoring session with ChatGPT for this. | 1.2content: p: symbols: \b\w+\b: count: 12 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.2 |
If there are only three statuses maybe the HTTP status code idea… | 3content: p: symbols: \b\w+\b: count: 30 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 3 |
https://chatgpt.com/share/915e1875-a26a-4deb-b9fc-705e59f0212a | 0.9content: p: symbols: \b\w+\b: count: 9 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.9 |
[ 0.3 WXDAI ]
@whilefoo
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Review | Comment | 1 | 0.3 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
won't `getDeadline` return null if price label is not pr… | 0.3content: p: symbols: \b\w+\b: count: 11 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 multiplier: 0.25 | 1 | 0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
V1 will notice a user of its deadline when it is assigned through the UI using and bypassing the
/start
command, see here: ubiquity-os-marketplace/text-conversation-rewards#4 (comment)V2 should also be notifying the user for the deadline on self-assign, or generally UI assign.
Also applies on UI assign, example: ubiquity-os-marketplace/text-conversation-rewards#81 (comment)
The text was updated successfully, but these errors were encountered: