Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notify self assign #24

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Aug 20, 2024

Resolves #12

Depends on #21, #19

QA: Meniole#1 (comment)

@gentlementlegen
Copy link
Member Author

New QA: Meniole#10 (comment)

@gentlementlegen gentlementlegen marked this pull request as ready for review September 2, 2024 04:36
@gentlementlegen gentlementlegen marked this pull request as draft September 2, 2024 04:36
@gentlementlegen gentlementlegen marked this pull request as ready for review September 2, 2024 04:48
src/handlers/user-start-stop.ts Outdated Show resolved Hide resolved
@Keyrxng
Copy link
Member

Keyrxng commented Sep 3, 2024

Unsure exactly what's causing it considering the bubble-up logic remains unchanged as far as I can tell other than the addition of the proxy but it looks like it's throws the error instead of passing it to our comment wrapper

Mine:
image
Yours:
image

Copy link
Member

@Keyrxng Keyrxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an issue with posting error comments

#34 (comment)

@gentlementlegen
Copy link
Member Author

There seems to be an issue with posting error comments

#34 (comment)

Is it directly related to this pull-request or not? If so I will fix here, if not I'll do that on another PR.

@Keyrxng
Copy link
Member

Keyrxng commented Sep 4, 2024

Odd that the Proxy messed with bubbling up the error that's something I'll need to look into in telegram-bot as I've leaned on the same approach there.

for a Time: <1 Hour task we seem to be getting a deadline of now()

I swear I don't use Microsoft Copilot

image

and Time: <2 hour gets a time of now() + 1

image

Is this intended?


I guess this is a separate issue below.

But didn't we used to give a buffer as opposed to using the raw time string? I bring this up because if contributors start to get negative XP for being beyond the deadline or lesser rewards because of it then surely the opposite should be true for tasks which get "completed" within the deadline.

"Completed" is also subjective here, is that time til PR or time til closed-as-complete?

@gentlementlegen
Copy link
Member Author

@Keyrxng time is given in UTC, so I don't know the time zone you are in but that should be the reason. If not, I didn't change the code logic (I think) to get the deadline: https://github.com/ubiquibot/command-start-stop/pull/24/files#diff-0d8c330f3d4a9c9fe27deaf9eb73ede2d9bb6016940d6d24cd112688d819ecf5L15

And I think completed should be PR opening + ready to review, being merged in 1 hours sounds unrealistic.

@Keyrxng
Copy link
Member

Keyrxng commented Sep 6, 2024

I didn't change the code logic (I think) to get the deadline

That'll be my mistake then my bad. My timezone is UTC+00 which I'm sure is the same as the reminder, do you think you could add a + 1 so that it's achievable to complete a 1hr task within the deadline?

And I think completed should be PR opening + ready to review, being merged in 1 hours sounds unrealistic.

Agreed lol. And with issue/PR activity bumping it forward technically it's not a strict deadline either so calculating a bonus/negative based on the deadline seems like it will be a difficult task actually.

@gentlementlegen
Copy link
Member Author

@Keyrxng sure I can check that time issue and add some tests within a separate pull request.

Probably should use some averages / lean methods for xp calculations.

@gentlementlegen gentlementlegen merged commit 2be6491 into ubiquity-os-marketplace:development Sep 7, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the feat/notify-self-assign branch September 7, 2024 04:17
@0x4007
Copy link
Member

0x4007 commented Sep 8, 2024

What is this about timing and XP? There is no approved proposal related to this.

XP is derived only from dollar rewards, plus adjustments.

No dollar rewards are related to deadlines and timing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify user on the deadline when assigned manually
5 participants