Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/required start labels #80

Conversation

Keyrxng
Copy link
Member

@Keyrxng Keyrxng commented Nov 7, 2024

Resolves #79

QA: ubq-testing#25

@Keyrxng
Copy link
Member Author

Keyrxng commented Nov 7, 2024

@rndquu ready for review

The spec sounds like "Every body stop what your doing let's reassess and take on something important if you're haven't already" and I'm here for it

P.S: Can you update the org settings so we can request reviews for real?

@rndquu
Copy link
Member

rndquu commented Nov 7, 2024

Can you update the org settings so we can request reviews for real?

@Keyrxng As far as I understand you don't have permissions to ask for a review. I couldn't find this option in github organization settings. Where is it located?

@rndquu rndquu self-requested a review November 7, 2024 15:34
@rndquu
Copy link
Member

rndquu commented Nov 7, 2024

@Keyrxng Could you update the logic?

  1. Set requiredLabelsToStart array empty by default (to make the plugin backwards compatible)
  2. If requiredLabelsToStart array is empty then allow /start
  3. If requiredLabelsToStart array is not empty then check that label from requiredLabelsToStart exists in github issue labels

@rndquu
Copy link
Member

rndquu commented Nov 7, 2024

@Keyrxng Also could you update the readme file with the requiredLabelsToStart option?

@Keyrxng
Copy link
Member Author

Keyrxng commented Nov 7, 2024

Empty array QA: ubq-testing#25 (comment)

@rndquu
Copy link
Member

rndquu commented Nov 7, 2024

@Keyrxng I've sent invite to the https://github.com/ubiquity-os-marketplace org, perhaps when you're a member you can ask for reviews

@Keyrxng
Copy link
Member Author

Keyrxng commented Nov 7, 2024

Thanks I appreciate it and I hope so as it's too easy to lose review requests via mention

@rndquu
Copy link
Member

rndquu commented Nov 8, 2024

@Keyrxng Could you resolve the code conflicts? I suppose the PR is safe to merge afterwards.

Copy link
Member

@gentlementlegen gentlementlegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflict and review my comment, then good to go.

My QA after the fix I suggested: Meniole#47 (comment)

@Keyrxng
Copy link
Member Author

Keyrxng commented Nov 8, 2024

Can be merged when ready I think

@rndquu rndquu merged commit 844cac7 into ubiquity-os-marketplace:development Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New config property requiredLabelsToStart
3 participants