-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/required start labels #80
Feat/required start labels #80
Conversation
@rndquu ready for review The spec sounds like "Every body stop what your doing let's reassess and take on something important if you're haven't already" and I'm here for it P.S: Can you update the org settings so we can request reviews for real? |
@Keyrxng As far as I understand you don't have permissions to ask for a review. I couldn't find this option in github organization settings. Where is it located? |
@Keyrxng Could you update the logic?
|
@Keyrxng Also could you update the readme file with the |
Empty array QA: ubq-testing#25 (comment) |
@Keyrxng I've sent invite to the https://github.com/ubiquity-os-marketplace org, perhaps when you're a member you can ask for reviews |
Thanks I appreciate it and I hope so as it's too easy to lose review requests via mention |
@Keyrxng Could you resolve the code conflicts? I suppose the PR is safe to merge afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the merge conflict and review my comment, then good to go.
My QA after the fix I suggested: Meniole#47 (comment)
Can be merged when ready I think |
Resolves #79
QA: ubq-testing#25