Implement TypeBox for Environment Variable Management #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the `generateErc721PermitSignature` function to improve the handling of environment variables related to NFT minting. The following changes have been made: - **Optional Fields**: Updated the environment variable checks to ensure that `NFT_MINTER_PRIVATE_KEY` and `NFT_CONTRACT_ADDRESS` are treated as optional. If these variables are not defined, appropriate error messages are logged, and exceptions are thrown. - **Type Safety**: Introduced a type cast for `contextOrPermitPayload.env` to `Env`, ensuring type safety when accessing environment variables. - **Error Handling**: Enhanced error handling by providing clear messages for missing required fields, improving debugging and user feedback. These changes aim to make the permit generation process more robust and flexible, accommodating scenarios where certain environment variables may not be set.
|
Please prove it works by posting QA of some sort |
|
@luisantoniocrag, this task has been idle for a while. Please provide an update. |
1 similar comment
|
@luisantoniocrag, this task has been idle for a while. Please provide an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the task of integrating TypeBox for managing environment variables as outlined in issue #88.
Changes Made:
NFT_MINTER_PRIVATE_KEYandNFT_CONTRACT_ADDRESSare now optional, allowing for more flexible configuration in different environments.These changes improve the robustness and maintainability of the codebase by leveraging TypeBox's capabilities for environment variable management.
Resolves #88