-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove SDK files and update dependencies #193
fix: remove SDK files and update dependencies #193
Conversation
Deleted `src/sdk` directory, adjusted dependencies, and updated relevant imports.
Deleted manifest definition and sdk tests. Updated dependencies and workflow for simpler release.
Deleted tsup.config.ts as it's no longer needed for the build process.
I'm not sure what you mean by that. Do you mean to move signature creation/verification functions inside the SDK and import them from SDK in the kernel? |
@whilefoo Yes exactly, this way the encode / decode happens in the same package which seems to make more sense to me. |
Yeah it makes sense because when you modify encode, you also need to modify decode so if it was separate you would need to update both packages |
Indeed. Then I will move the encode logic as well and include the package here. |
Replace link dependency with versioned dependency in package.json.
@whilefoo moved this in a signature import within the SDK: https://github.com/ubiquity-os/ubiquity-os-kernel/pull/193/files#diff-9d1e92d5ff6f0b749097b71ca93f176a78310fe4c8da4d615811d4c128df2050R7 |
Deleted
src/sdk
directory, adjusted dependencies, and updated relevant imports. The new SDK is located at https://github.com/ubiquity-os/plugin-sdkResolves #192
@whilefoo I wonder if it makes sense to move the signature within the SDK as well. The problem now is that the signature gets created inside the kernel and decoded within the SDK which is prone to error. Related PR: ubiquity-os/plugin-sdk#22