Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fetch manifests #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Keyrxng
Copy link
Member

@Keyrxng Keyrxng commented Nov 7, 2024

Resolves #4

Why I choose to do it like this:

  1. If we pull from our ubiquityos-config.yml, that's all the plugins which are active and installable (in theory as quite a few produce errors when fetching their manifest)
  2. We could just pull the manifest content from each repo but not guaranteed that plugin is active.
  3. I think it's better UX if we have one portal which has all the plugins ready to be installed and we can list them or carousel them or something and one-click install/optional user input on configurations.

I could just read the manifest.json directly from each repo in -marketplace instead if that's the 'official' marketplace for installable plugins.

You've always been the CSS guy between us @0x4007, I lack the finesse, maybe a task specifically for handling the huge configs and designing config customizations

QA:

image

image

If you look at the worker URL keys in localStorage they look kinda messy. We should update them to all have uniform names if possible.

@0x4007
Copy link
Member

0x4007 commented Nov 10, 2024

Might need to reopen this pull to exclude the template diff

@Keyrxng
Copy link
Member Author

Keyrxng commented Nov 11, 2024

I pretty much abandoned my approach used in this PR but used the manifest fetching logic in #13.

I realized that it's cleaner to just parse manifests directly from the marketplace than to parse our configs for active plugins then fetch them via the pluginUrl because there shouldn't be an unstable or inactive plugin within the -marketplace repo.

If you look at the worker URL keys in localStorage they look kinda messy. We should update them to all have uniform names if possible.

Also because this proved to be a problem recently that configs contained outdated worker endpoints so fetching the manifest that way failed for more than a few.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse & import remote manifest.json
2 participants