refactor: replace syncIssueMetaData with updateDirectoryIssue and upd… #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate parameter names for clarity
0x4007
commented
Oct 27, 2024
| import { commitTwitterMap } from "../git"; | ||
|
|
||
| export type TwitterMap = Record<string, string>; | ||
|
|
||
| export async function initializeTwitterMap() { | ||
| let twitterMap: TwitterMap = {}; | ||
| try { | ||
| twitterMap = JSON.parse(await readFile("./twitter-map.json", "utf8")); | ||
| const response = await fetch("https://raw.githubusercontent.com/0x4007/devpool-directory/__STORAGE__/twitter-map.json"); |
There was a problem hiding this comment.
This was out of scope but it wasn't working before. But to be clear I didn't focus on testing this.
Unused files (3)
Unused dependencies (1)
Unused devDependencies (6)
Unlisted dependencies (7)
Unlisted binaries (2)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ate parameter names for clarity
Resolves ubiquity/devpool-directory-tasks#54
QA: https://github.com/0x4007/devpool-directory/actions/runs/11536021329/job/32111752753
260 -> 218 open issues after this run which is aligned with my expectation of how many issues were closed since I pushed the broken code.