Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from field in #additionalDetails overflow #312

Open
Keyrxng opened this issue Sep 19, 2024 · 12 comments · May be fixed by #336
Open

from field in #additionalDetails overflow #312

Keyrxng opened this issue Sep 19, 2024 · 12 comments · May be fixed by #336

Comments

@Keyrxng
Copy link
Member

Keyrxng commented Sep 19, 2024

image

This overflow should be taken care of neatly similar to how we handle other overflows regarding address and ENS name

@hydroxylase
Copy link
Contributor

/start

Copy link
Contributor

ubiquity-os bot commented Sep 19, 2024

Deadline Thu, Sep 19, 6:29 PM UTC
Beneficiary 0x229674f3db146E0AF0182b660F5c9232538E7e7b

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link
Contributor

ubiquity-os bot commented Sep 23, 2024

@CaptainPrinz, this task has been idle for a while. Please provide an update.

@hydroxylase
Copy link
Contributor

@CaptainPrinz, this task has been idle for a while. Please provide an update.

Apologies. I've been preoccupied with other tasks lately.
Will work on it today

Copy link
Contributor

ubiquity-os bot commented Oct 4, 2024

@hydroxylase, this task has been idle for a while. Please provide an update.

@zugdev
Copy link
Contributor

zugdev commented Oct 14, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Oct 14, 2024

Deadline Mon, Oct 14, 10:00 PM UTC
Beneficiary 0xbB689fDAbBfc0ae9102863E011D3f897b079c80F

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@zugdev
Copy link
Contributor

zugdev commented Oct 14, 2024

I can never get the "For" address to be full. Is that intended? If not could be an issue.

image

@zugdev
Copy link
Contributor

zugdev commented Oct 14, 2024

Apparently what toggles full and short for the main table screen is if details is toggled or not, it doesn't make sense at least in current context where details hides main.

table[data-details-visible="false"] #rewardToken .full,
table[data-details-visible="true"] #rewardToken .short {
display: none;
}
table[data-details-visible="false"] #rewardToken .short,
table[data-details-visible="true"] #rewardToken .full {
display: initial;
}
table[data-details-visible="false"] #rewardRecipient .full,
table[data-details-visible="true"] #rewardRecipient .short {
display: none;
}
table[data-details-visible="false"] #rewardRecipient .short,
table[data-details-visible="true"] #rewardRecipient .full {
display: initial;

@zugdev zugdev linked a pull request Oct 14, 2024 that will close this issue
@zugdev
Copy link
Contributor

zugdev commented Oct 14, 2024

The above PR handles shortening in the same way it's currently handled. If you want to change the shortening condition let me know.

@zugdev
Copy link
Contributor

zugdev commented Oct 15, 2024

The PR now changes the approach to shorten the addresses in a dynamic way. A demo can be watched inside the issue.

Copy link
Contributor

ubiquity-os bot commented Nov 8, 2024

Passed the deadline and no activity is detected, removing assignees: @zugdev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants