Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From field in #additionalDetailsTable #314

Closed
wants to merge 4 commits into from

Conversation

hydroxylase
Copy link
Contributor

Resolves #312

@hydroxylase
Copy link
Contributor Author

@Keyrxng requesting review

Copy link
Member

@Keyrxng Keyrxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hydroxylase for future PRs please try to include a screenshot or some other form of visual confirmation, thank you.

I suppose it doesn't really affect anything in this context in terms of Web3 Security but as a best practice typically you'd show the beginning and the end of the address just like the FOR field:

image

It seems we are not making the most effective use of whitespace on various views and is exaggerated by the fact the allowance field is longer than the address itself.

image

@0x4007
Copy link
Member

0x4007 commented Sep 24, 2024

@rndquu I looked through the GitHub Actions logs of our continuous Cloudflare deploys and we seem to have some problem with targeting the correct names.

This attempted to use https://ubiquity-ubiquity-dollar.pay-ubq-fi.pages.dev

Is it possible that the script is having some collisions from our other repos? Sometime of contamination during its run?

@hydroxylase hydroxylase closed this by deleting the head repository Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from field in #additionalDetails overflow
3 participants