Chore/test empty string 2 #66
Conversation
![ubiquity-os-deployer[bot]](https://avatars.githubusercontent.com/in/834196?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
0x4007
force-pushed
the
chore/test-empty-string-2
branch
from
b003b80
to
61261e4
Compare
|
I got annotations working on the files view but I can't get the line targeting to be accurate. |
0x4007
force-pushed
the
chore/test-empty-string-2
branch
from
e4a3ef1
to
61261e4
Compare
…ty/ts-template into chore/test-empty-string-2
0x4007
force-pushed
the
chore/test-empty-string-2
branch
from
e7149c3
to
1f2e6d4
Compare
|
Currently matches any instance of Will leave it looser targeting for now. |
|
@0x4007 It seems you merged this with empty strings: https://github.com/ubiquity/ts-template/actions/runs/11245674853/job/31266132517 could this be fixed? |
|
It's a warning not an error. This expresses that the reviewers should be cautious and review its context. It should never warn for the same string again because it is designed only to check the pull diff. To be fair this probably would work by using |
|
Also I just realized that it doesn't display annotations on GitHub mobile which is extremely unfortunate. At least the CI should clearly indicate a failure. |
Resolves #31
Currently matches any instance of
""but with regex can do more precise targeting (in the future if necessary) i.e. look forconstorletin the same line to identify variable initializations, which is the primary suspect.Will leave it looser targeting for now as an open experiment to take note of other specific scenarios to focus on later