fix: Framework 13 AMD support #106
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
RealVishy
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues with the system setup script:
$SYS_IDis not defined anywhere, so we never actually take the branch to compare the product name.I'm assuming
$SYS_IDis supposed to be defined as the contents of/sys/devices/virtual/dmi/id/product_name, which is from Bazzite's/usr/libexec/hwsupport/sysid. This string is something likeLaptop 13 (AMD Ryzen 7040Series)which doesn't match the regexLaptop (*.I discovered this when I noticed that I didn't have any of these tweaks on my Framework 13. I checked the first log entry for
ublue-system-setup.serviceand it completed succesfully, but the script didn't take the correct branch and apply the tweaks because of the above issues.