Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move fastfetch configuration to ublue-fastfetch #109

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tulilirockz
Copy link
Contributor

@tulilirockz tulilirockz commented Jan 11, 2025

This should move all the fastfetch configs to ublue-fastfetch. This still needs some configuration on fastfetch.jsonc to include the logo directly there, or we can update the ublue-fastfetch package first

@tulilirockz tulilirockz requested a review from castrojo as a code owner January 11, 2025 14:51
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 11, 2025
@tulilirockz
Copy link
Contributor Author

Alright! It works nicely!
image

@tulilirockz
Copy link
Contributor Author

@ledif I wanted to put you as a reviewer but I cant for some reason.

@ledif
Copy link
Collaborator

ledif commented Jan 11, 2025

I think something might be missing. Just tested it out on a VM and this is what I see:

Screenshot_20250111_093840

@tulilirockz
Copy link
Contributor Author

I think something might be missing. Just tested it out on a VM and this is what I see:

Could you try running /usr/libexec/ublue-fastfetch? It might work. I think the package is missing some profile.d hooks

@tulilirockz
Copy link
Contributor Author

Just checked the package. The hooks should be there, on /etc/profile.d/ublue-fastfetch.sh. Maybe they're not executable? Or they're just mistyped somehow? It works on Achillobator so that is quite weird

@tulilirockz
Copy link
Contributor Author

Omg @ledif i literally forgot to add the package to packages.json LMAO

@ledif
Copy link
Collaborator

ledif commented Jan 11, 2025

Omg @ledif i literally forgot to add the package to packages.json LMAO

Ah, okay! I didn't see any of the files and ran a rpm-ostree db list <commit> | grep ublue and was like, there is no fastfetch package here... 😅

@ledif
Copy link
Collaborator

ledif commented Jan 11, 2025

Okay, seems to be working now!
Screenshot_20250111_100748

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 11, 2025
@ledif
Copy link
Collaborator

ledif commented Jan 11, 2025

Let's wait until after stable images are released tonight before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants