-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose endpoint for category filtering #70
Conversation
BTW, this deletes the repeated protobuf |
I'm stuck on the sql queries, another pair of eyes would help. |
Hi Zoe, what part are you stuck on? |
so the there also might be a problem with the chart filtering but its hard to tease apart since theyre so correlated. Edit: actually, this is a snapd query issue, it appears to be very finnicky to get snaps by ID. The |
c9c052d
to
5fdc03a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes please. Can you also squash your commits so atomic features ... also try and keep tests as their own commit.
efcc672
to
e99a8ed
Compare
Hmm, GHA is failing because E: Yup, The snap hasn't been updated since 2021, need to move to the deb. |
5444d48
to
e99a8ed
Compare
Blocked on #77 because it's needed to get github actions to pass. |
e99a8ed
to
188be5a
Compare
This foregos a SQL enum in favor of constraining the input to the range of the protobuf enum, this allows the same idea as an enum but works around some limitations with `prost` using `#[repr(i32)]` on its enums which messes with `sqlx`'s derives.
f60de84
to
739f664
Compare
This relies on
snapd-rs
to work, and adds a couple dependencies to make life less miserable.As requested, this just looks up the queries on every call to
vote
orget_vote
in the hope thateventually all the categories will be populated.
Closes #60