Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changing the password if refreshing token or user info fails #350

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

adombeck
Copy link
Contributor

We don't need to refresh the token and user info if the session is for changing the password.

@adombeck adombeck marked this pull request as ready for review January 29, 2025 16:06
@adombeck adombeck requested a review from a team as a code owner January 29, 2025 16:06
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn’t that be backed by some tests, or at least, should have impacted some?

We don't need to refresh the token and user info if the session is for
changing the password.
@adombeck
Copy link
Contributor Author

adombeck commented Feb 3, 2025

I added a test

@adombeck adombeck force-pushed the support-changing-password-if-refresh-token-fails branch from 8498ab4 to fc8abea Compare February 3, 2025 15:02
@adombeck adombeck requested a review from didrocks February 3, 2025 15:02
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

@adombeck adombeck merged commit e7141e4 into main Feb 3, 2025
3 of 4 checks passed
@adombeck adombeck deleted the support-changing-password-if-refresh-token-fails branch February 3, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants