maint(pam/nativemodel): Improve wording and consistency of strings #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
native-wording-improvements
branch
from
4c3c4f7 to
9087e8d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
+ Coverage 82.86% 82.93% +0.07%
==========================================
Files 80 80
Lines 8514 8534 +20
Branches 75 75
==========================================
+ Hits 7055 7078 +23
+ Misses 1129 1127 -2
+ Partials 330 329 -1 ☔ View full report in Codecov by Sentry. |
adombeck
reviewed
Oct 21, 2024
3v1n0
force-pushed
the
native-wording-improvements
branch
2 times, most recently
from
07cc197 to
6a23cee
Compare
adombeck
reviewed
Oct 22, 2024
3v1n0
force-pushed
the
native-wording-improvements
branch
from
6a23cee to
651c697
Compare
adombeck
reviewed
Oct 22, 2024
adombeck
reviewed
Oct 22, 2024
adombeck
reviewed
Oct 22, 2024
3v1n0
force-pushed
the
native-wording-improvements
branch
from
651c697 to
ca979f1
Compare
3v1n0
force-pushed
the
native-wording-improvements
branch
from
ca979f1 to
5de61a1
Compare
adombeck
reviewed
Oct 22, 2024
denisonbarbosa
approved these changes
Oct 22, 2024
Use the same terminology and similar behavior of the CLI mode
We were trying to fix the broker behavior here, but it's something that was done only by the native UI and it's not really something used anywhere. So instead just error in case this happens, since we expect to have defined labels here. In case we will ever require to have a fallback string, this should be done at general level and not just at PAM level.
Make it clearer where a "go back" action will lead the user to.
Use a behavior that is more similar to what we've in the CLI interface so that when an input is requested the `>` char is used.
3v1n0
force-pushed
the
native-wording-improvements
branch
from
5de61a1 to
f55d343
Compare
In native modules the prompt should be only the text shown on the field, while the rest of information should be exposed as PAM info messages. Do this to ensure that both all PAM implementations we care about (ssh and polkit) keep a reasonable UI.
3v1n0
force-pushed
the
native-wording-improvements
branch
from
f55d343 to
79f21be
Compare
adombeck
reviewed
Nov 6, 2024
adombeck
approved these changes
Nov 6, 2024
Co-Authored-By: Adrian Dombeck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same terminology and similar behavior of the CLI mode
UDENG-5012