fix: Square Windows title controls (#967)

* Square Windows title controls * Update windows title bar tests
ubuntu · Dec 3, 2024 · e81046e · e81046e
1 parent ca0e8ee
commit e81046e
Show file tree

Hide file tree

Showing 48 changed files with 4 additions and 4 deletions.
diff --git a/lib/src/widgets/yaru_window_control.dart b/lib/src/widgets/yaru_window_control.dart
@@ -8,7 +8,7 @@ import 'package:yaru/theme.dart';
 const kYaruWindowControlSize = 24.0;
 
 /// The size of a [YaruWindowControl] on the [YaruWindowControlPlatform.windows] platform.
-const kYaruWindowsWindowControlSize = Size(44, 28);
+const kYaruWindowsWindowControlSize = 46.0;
 
 const _kWindowControlIconStrokeWidth = 1.0;
 const _kWindowControlIconStrokeAlign = _kWindowControlIconStrokeWidth / 2;
@@ -322,8 +322,8 @@ class _YaruWindowControlState extends State<YaruWindowControl>
               )
             : null,
       ),
-      child: SizedBox.fromSize(
-        size: kYaruWindowsWindowControlSize,
+      child: SizedBox.square(
+        dimension: kYaruWindowsWindowControlSize,
         child: child,
       ),
     );

diff --git a/test/widgets/goldens/yaru_title_bar-windows-closable-dark.png b/test/widgets/goldens/yaru_title_bar-windows-closable-dark.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-closable-light.png b/test/widgets/goldens/yaru_title_bar-windows-closable-light.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-dialog-dark.png b/test/widgets/goldens/yaru_title_bar-windows-dialog-dark.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-dialog-light.png b/test/widgets/goldens/yaru_title_bar-windows-dialog-light.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-dialog-red-dark.png b/test/widgets/goldens/yaru_title_bar-windows-dialog-red-dark.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-dialog-red-light.png b/test/widgets/goldens/yaru_title_bar-windows-dialog-red-light.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-empty-dark.png b/test/widgets/goldens/yaru_title_bar-windows-empty-dark.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-empty-light.png b/test/widgets/goldens/yaru_title_bar-windows-empty-light.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-inactive-dark.png b/test/widgets/goldens/yaru_title_bar-windows-inactive-dark.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-inactive-light.png b/test/widgets/goldens/yaru_title_bar-windows-inactive-light.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-maximizable-dark.png b/test/widgets/goldens/yaru_title_bar-windows-maximizable-dark.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-maximizable-light.png b/test/widgets/goldens/yaru_title_bar-windows-maximizable-light.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-restorable-dark.png b/test/widgets/goldens/yaru_title_bar-windows-restorable-dark.png
diff --git a/test/widgets/goldens/yaru_title_bar-windows-restorable-light.png b/test/widgets/goldens/yaru_title_bar-windows-restorable-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-close-dark.png b/test/widgets/goldens/yaru_window_control-windows-close-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-close-disabled-dark.png b/test/widgets/goldens/yaru_window_control-windows-close-disabled-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-close-disabled-light.png b/test/widgets/goldens/yaru_window_control-windows-close-disabled-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-close-hovered-dark.png b/test/widgets/goldens/yaru_window_control-windows-close-hovered-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-close-hovered-light.png b/test/widgets/goldens/yaru_window_control-windows-close-hovered-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-close-light.png b/test/widgets/goldens/yaru_window_control-windows-close-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-close-pressed-dark.png b/test/widgets/goldens/yaru_window_control-windows-close-pressed-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-close-pressed-light.png b/test/widgets/goldens/yaru_window_control-windows-close-pressed-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-maximize-dark.png b/test/widgets/goldens/yaru_window_control-windows-maximize-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-maximize-disabled-dark.png b/test/widgets/goldens/yaru_window_control-windows-maximize-disabled-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-maximize-disabled-light.png b/test/widgets/goldens/yaru_window_control-windows-maximize-disabled-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-maximize-hovered-dark.png b/test/widgets/goldens/yaru_window_control-windows-maximize-hovered-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-maximize-hovered-light.png b/test/widgets/goldens/yaru_window_control-windows-maximize-hovered-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-maximize-light.png b/test/widgets/goldens/yaru_window_control-windows-maximize-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-maximize-pressed-dark.png b/test/widgets/goldens/yaru_window_control-windows-maximize-pressed-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-maximize-pressed-light.png b/test/widgets/goldens/yaru_window_control-windows-maximize-pressed-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-minimize-dark.png b/test/widgets/goldens/yaru_window_control-windows-minimize-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-minimize-disabled-dark.png b/test/widgets/goldens/yaru_window_control-windows-minimize-disabled-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-minimize-disabled-light.png b/test/widgets/goldens/yaru_window_control-windows-minimize-disabled-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-minimize-hovered-dark.png b/test/widgets/goldens/yaru_window_control-windows-minimize-hovered-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-minimize-hovered-light.png b/test/widgets/goldens/yaru_window_control-windows-minimize-hovered-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-minimize-light.png b/test/widgets/goldens/yaru_window_control-windows-minimize-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-minimize-pressed-dark.png b/test/widgets/goldens/yaru_window_control-windows-minimize-pressed-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-minimize-pressed-light.png b/test/widgets/goldens/yaru_window_control-windows-minimize-pressed-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-restore-dark.png b/test/widgets/goldens/yaru_window_control-windows-restore-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-restore-disabled-dark.png b/test/widgets/goldens/yaru_window_control-windows-restore-disabled-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-restore-disabled-light.png b/test/widgets/goldens/yaru_window_control-windows-restore-disabled-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-restore-hovered-dark.png b/test/widgets/goldens/yaru_window_control-windows-restore-hovered-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-restore-hovered-light.png b/test/widgets/goldens/yaru_window_control-windows-restore-hovered-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-restore-light.png b/test/widgets/goldens/yaru_window_control-windows-restore-light.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-restore-pressed-dark.png b/test/widgets/goldens/yaru_window_control-windows-restore-pressed-dark.png
diff --git a/test/widgets/goldens/yaru_window_control-windows-restore-pressed-light.png b/test/widgets/goldens/yaru_window_control-windows-restore-pressed-light.png
diff --git a/test/widgets/yaru_window_control_test.dart b/test/widgets/yaru_window_control_test.dart
@@ -50,7 +50,7 @@ void main() {
 
       if (variant.label.startsWith('windows')) {
         platform = YaruWindowControlPlatform.windows;
-        size = kYaruWindowsWindowControlSize;
+        size = const Size.square(kYaruWindowsWindowControlSize);
       } else {
         platform = YaruWindowControlPlatform.yaru;
         size = const Size.square(kYaruWindowControlSize);