Feat: make defaultRoles configurable #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and use it also instead of the existing security.ad.default.import.group
pieterlukasse
changed the title
pieterlukasse
commented
Apr 26, 2024
| @@ -108,6 +108,8 @@ csrf.disable=true | |||
| sparql.endpoint=http://virtuoso.ohdsi.org:8890/sparql?default-graph-uri=&query= | |||
|
|
|||
| security.defaultGlobalReadPermissions=${security.defaultGlobalReadPermissions} | |||
| #security.defaultRoles=${security.defaultRoles} | |||
| security.defaultRoles=public,read restricted Atlas Users | |||
There was a problem hiding this comment.
...and then we would also add role 'shared artifacts reader' (role 16) to this list, based on OHDSI/Atlas#2929
|
abandoned feature... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1062
New Features
Breaking Changes
security.ad.default.import.groupBug Fixes
Improvements