Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 640: Automated Mass Email for PCA/FCA Renewal #643

Closed
wants to merge 8 commits into from

Conversation

adeng27
Copy link
Collaborator

@adeng27 adeng27 commented Sep 13, 2024

Description

Historically, a mass notification email has been sent out letting all PIs/managers of “Active” PCAs/FCAs know that renewals for next year are ready. This all occurs manually and the emails are not tailored for the project in question. This request proposes that the process becomes automated (though it can be initiated manually) and that each email is tailored for its respective project.

This is initially implemented with a command that will use django-q to schedule a command call of itself x number of days before the start date of the next allocation period. Depending on a passed in argument, the function will optionally call the send_mass_renewal_emails (to be renamed) function when triggered. In send_mass_renewal_emails, the projects are split into batches so that emails are staggered out. Inside each batch, tailor an email for each project individually and send each using async_task from django-q.

Fixes #640

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit Testing in coldfront.core.project.tests.test_utils.test_renewal_utils.test_allowance_renewal_email
  • Manual Testing via Django Shell

PR Self Evaluation

Strikethrough things that don’t make sense for your PR.

  • My code follows the agreed upon best practices
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if needed)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in the appropriate modules
  • I have performed a self-review of my own code

@adeng27 adeng27 requested a review from matthew-li September 13, 2024 20:45
@adeng27 adeng27 self-assigned this Sep 13, 2024
@matthew-li
Copy link
Collaborator

Putting this on the backburner for now, since this occurs only 2x/year.

@matthew-li matthew-li closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants