Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated reduce.py to add caching mechanism for scratchpad #290

Closed
wants to merge 1 commit into from

Conversation

rrawatt
Copy link
Contributor

@rrawatt rrawatt commented Jan 24, 2025

  1. Added a new attribute store the cache
  2. Added a method to clear the cache in case of performance issues for a future date
  3. Modified _increment_fold, _merge_results, _batch_reduce methods to use the cache.

I was unable to test the new implementation. so please so go through it once.

@shreyashankar
Copy link
Collaborator

Closing since the scratchpad is already stored in memory and doesn't benefit from caching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants