Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/80 - decrease margin-top of embedded score page #86

Merged
merged 1 commit into from
Oct 9, 2020
Merged

issue/80 - decrease margin-top of embedded score page #86

merged 1 commit into from
Oct 9, 2020

Conversation

weining-li
Copy link
Contributor

@weining-li weining-li commented Oct 9, 2019 •
edited
Loading

It was difficult but I persevered and managed to come out with the "W"

#80

FrenjaminBanklin
FrenjaminBanklin previously approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak as to whether this solves the problem in the Obojobo implementation, but there's definitely less spare room at the top of the embedded score screen.

@clpetersonucf clpetersonucf changed the base branch from master to dev/2.2.0 November 21, 2019 15:58
@clpetersonucf clpetersonucf changed the base branch from dev/2.2.0 to dev/2.3.0 October 9, 2020 19:37
@clpetersonucf clpetersonucf dismissed FrenjaminBanklin’s stale review October 9, 2020 19:37

The base branch was changed.

@clpetersonucf clpetersonucf merged commit c946ff4 into ucfopen:dev/2.3.0 Oct 9, 2020
@iturgeon iturgeon mentioned this pull request Jan 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clpetersonucf clpetersonucf clpetersonucf approved these changes

@FrenjaminBanklin FrenjaminBanklin FrenjaminBanklin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weining-li @clpetersonucf @FrenjaminBanklin