fix bundleid not being defined

uchks · Oct 6, 2024 · 07fdef7 · 07fdef7
1 parent 472a0c3
commit 07fdef7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 8 deletions.
diff --git a/depictions/web/js/content-blocks-index.js b/depictions/web/js/content-blocks-index.js
@@ -1,3 +1,9 @@
+let bundleid = "";
+
+function setBundleId(id) {
+  bundleid = id;
+}
+
 function getContentBlocks() {
   return {
     "#packageName": {
@@ -64,7 +70,10 @@ function getContentBlocks() {
         );
       },
     },
-    "#versionBadge": { type: "text", source: "package>version" },
+    "#versionBadge": {
+      type: "text",
+      source: "package>version",
+    },
     "#changesList": {
       type: "list",
       source: "package>changelog>change",
@@ -103,22 +112,22 @@ function getContentBlocks() {
       source: "package>links>link",
       paragraphElement: "<li class='list-group-item'>",
       render: (element, source) => {
-        if ($(source).lenght === 0) {
+        if ($(source).length === 0) {
           $("#externalLinksContainer").remove();
+          return;
         }
 
         $.each(source, (index, data) => {
           const a = $("<a class='link-item list-group-item'>");
           a.attr("href", $(data).find("url").text());
-          if ($(data).find("iconclass")) {
+          if ($(data).find("iconclass").length) {
             const i = $("<span>");
             i.attr("class", $(data).find("iconclass").text());
-            console.log(i);
             $(a).append(i);
           }
           $(a).append($(data).find("name").text());
           $(element).append(a);
-        }); //each
+        });
       },
     },
   };
@@ -139,5 +148,5 @@ function populateContentBlocks(data, blocks, error, success) {
       $("#packageInformation").hide();
       error(textStatus);
     },
-  }); //ajax
+  });
 }
diff --git a/depictions/web/js/content-blocks-screenshots.js b/depictions/web/js/content-blocks-screenshots.js
@@ -1,3 +1,9 @@
+let bundleid = "";
+
+function setBundleId(id) {
+  bundleid = id;
+}
+
 function getContentBlocks() {
   return {
     "#screenshotsList": {
@@ -7,7 +13,7 @@ function getContentBlocks() {
         if ($(source).length === 0) {
           $(element).append(
             $(
-              "<div class='alert alert-danger'>The aren't any screenshots for this package</div>"
+              "<div class='alert alert-danger'>There aren't any screenshots for this package</div>"
             )
           );
           return;
@@ -43,5 +49,5 @@ function populateContentBlocks(data, blocks, error, success) {
       $("#packageInformation").hide();
       error(textStatus);
     },
-  }); //ajax
+  });
 }