Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and annotate root Facet classification; align core:hasFacet #7

Merged
merged 1 commit into from
May 8, 2024

Conversation

ajnelson-nist
Copy link
Contributor

No description provided.

No effects were observed on Make-managed files.

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist marked this pull request as ready for review March 8, 2024 16:35
@ajnelson-nist ajnelson-nist requested a review from a team as a code owner March 8, 2024 16:35
@ajnelson-nist
Copy link
Contributor Author

@plbt5 , this PR is ready for your review.

I have separately caught PR #5 up with this PR, so if you merge 5, 7 will be merged automatically.

@ajnelson-nist
Copy link
Contributor Author

@plbt5 I separated the alignment in this PR because I realized there is at least one Facet subclass that could complicate where the alignment lands. I think it is safe to merge this PR and then hold the discussion with the OCs.

@plbt5 plbt5 merged commit 56849d5 into main May 8, 2024
1 check passed
@ajnelson-nist ajnelson-nist deleted the add_root_facet_classification branch June 6, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants