Classify AnalyticResult and Assertion #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
|
This PR is ready for review and merge. |
plbt5
reviewed
Jun 5, 2024
| @@ -151,6 +152,18 @@ uco-action:startTime | |||
| ; | |||
| . | |||
|
|
|||
| uco-analysis:AnalyticResult | |||
| a gufo:SubKind ; | |||
| . | |||
There was a problem hiding this comment.
Since uco-analysis:AnalyticResult is typed as a gufo:SubKind is should also be a superclass of the ultimate sortal, i.e., a gufo:Kind where it gets its identitity criterion from. I seem to miss that here.
There was a problem hiding this comment.
Ah, sorry, it was a bit obscured by me not repeating triples from UCO. analysis:AnalyticResult is a direct subclass of core:Assertion:
https://github.com/ucoProject/UCO/blob/1.3.0/ontology/uco/analysis/analysis.ttl#L34-L39
plbt5
reviewed
Jun 5, 2024
I suspect it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.