Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 596: Restructure Software class hierarchy for UCO 1.4.0 #597

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Mar 6, 2024

This Pull Request resolves all backwards-compatible requirements of Issue #596 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (86e1cbd)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (4ca9dfd)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora
  • Impact on SHACL validation reviewed for CASE-Examples (Note: Incorrect Issue referenced in commit message; should be 596)
  • Impact on SHACL validation remediated for CASE-Examples
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

References:
* #596

Co-authored-by: Sean Barnum <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist added this to the UCO 1.4.0 milestone Mar 6, 2024
@ajnelson-nist ajnelson-nist linked an issue Mar 6, 2024 that may be closed by this pull request
16 tasks
Signed-off-by: Alex Nelson <[email protected]>
This patch also updates a test result from one of the to-be-rearranged
classes.

A follow-on patch will regenerate Make-managed files.

References:
* RDFLib/pySHACL#222
* #596
* https://www.w3.org/TR/shacl/#NodeConstraintComponent

Signed-off-by: Alex Nelson <[email protected]>
References:
* #596

Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist and others added 4 commits May 8, 2024 16:54
… class

This applies a practice being tried in Issue 602.

A follow-on patch will regenerate Make-managed files.

References:
* #596
* #602

Signed-off-by: Alex Nelson <[email protected]>
References:
* #596

Signed-off-by: Alex Nelson <[email protected]>
No effects were observed on Make-managed files.

AJN: This is my transcription of Sean's Issue Comment (see references),
with a few minor grammatical and typographical fixes.

References:
* #596 (comment)

Signed-off-by: Alex Nelson <[email protected]>
No effects were observed on Make-managed files.

References:
* #596

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Copy link
Contributor Author

Mild scope creep: I've incorporated a typo fix on WindowsComputerSpecification (a class @sbarnum noted in discussion) in 650a274.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructuring the Software class hierarchy
2 participants