Add negative-zero.c test to document ksh bug #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While working on #64, I tried running the compile the tests using
pnut.sh
(instead ofpnut-sh
compiled by gcc as it is usually done) and found thatpnut.sh
would compile thetests/_all/preprocessor/if/if.c
test differently. Code guarded by a#elif
block was not included because the flag we used to check if a previous condition was true was-0
and the code compared it to0
using string comparison (as an optimization) which are obviously different.This PR adds a test so we can track this bug.
This simple script also shows the bug:
I have only been able to reproduce the issue when using ksh on ARM. Other shells and ksh in a x86 VM show the expected behavior. This is similar to this issue found by @leo-ard where an undefined behavior in ksh produced different results in the x86 and ARM versions, and it may be indirectly caused by the use of floating point numbers to do all arithmetic in ksh.
Ksh version: