Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting step within GitHub Actions workflow #196

Closed
wants to merge 5 commits into from
Closed

Add linting step within GitHub Actions workflow #196

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1d89cf
Add eslint configs for both backend and frontend
aaditkamat Mar 4, 2024
4bc320e
Add lint step to GitHub workflow
aaditkamat Mar 4, 2024
bd3c4a4
Split workflow into different jobs
aaditkamat Mar 14, 2024
6ac62d2
Synced repo, fixed merge conflicts
h1divp Mar 20, 2024
3f4e285
fixing main.yaml to run separate tasks
AlexanderWangY Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,10 @@ jobs:
- name: Run tests
run: npm test
working-directory: server/

- name: Linting
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this a separate job, possibly called Linting or something like that.

We don't want to attach jobs with different functionalities to the same job! This makes it easier to "fix" when it throws a failed test!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, there are a lot of steps in that job to begin with. I'll shift some of the other steps into seperate jobs as well.

run: |
cd server/
npm run lint:fix
cd ../client/
npm run lint:fix
32 changes: 32 additions & 0 deletions client/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
module.exports = {
"env": {
"browser": true,
"es2021": true
},
"extends": [
"standard-with-typescript",
"plugin:react/recommended"
],
"overrides": [
{
"env": {
"node": true
},
"files": [
".eslintrc.{js,cjs}"
],
"parserOptions": {
"sourceType": "script"
}
}
],
"parserOptions": {
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": [
"react"
],
"rules": {
}
}
Loading
Loading