Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing nc back from microphysics #109

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

AnningCheng-NOAA
Copy link
Collaborator

passing nc back from microphysics is the main reason for the bug fixing, pass nifa and nwfa back is more or less for diagnostic purpose

physics/module_mp_thompson.F90 Show resolved Hide resolved
@jkbk2004
Copy link

@grantfirl can you help @AnningCheng-NOAA to sync up the branch?

@grantfirl
Copy link
Collaborator

@grantfirl can you help @AnningCheng-NOAA to sync up the branch?

Sure.

@grantfirl
Copy link
Collaborator

@jkbk2004 @AnningCheng-NOAA This branch is synced to the latest ufs/dev.

Anning, it looks like you synced to the NCAR/main branch instead of the ufs-community/ufs/dev branch, but I've fixed it. If you make sure that I'm a collaborator (how to do this) on your branches of fv3atm and ufs-weather-model, I'll sync those up too. My GitHub username is @grantfirl

@AnningCheng-NOAA
Copy link
Collaborator Author

@grantfirl you are added
grant_collbrt

@grantfirl
Copy link
Collaborator

@AnningCheng-NOAA I know that I am a collaborator for your ccpp-physics fork, but I need to be a collaborator on your fv3atm and ufs-weather-model forks to be able to push commits to them.

@AnningCheng-NOAA
Copy link
Collaborator Author

AnningCheng-NOAA commented Oct 12, 2023 via email

@zach1221
Copy link

@grantfirl , we are finished with testing on ufs-wm PR #1915 . Please feel free to merge this ccpp-physics PR when you're able.

@grantfirl grantfirl merged commit 69c9764 into ufs-community:ufs/dev Oct 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants