Convert GFS DDTs from blocked data structures to contiguous arrays (aka update GFS_debug.F90)

[climbfuji]

Description

In the UFS atmospheric component fv3atm and submodules, convert internal GFS DDTs from blocked data structures to contiguous arrays. This excludes the (external) GFS_extdiag and GFS_restart DDTs. Also remove the GFS_Data super DDT and use the individual DDTs directly.

For ccpp-physics, this only affects the (apparently unused) GFS_debug.{f90,meta} files. We could consider removing them entirely instead of updating them, since they don't get used?

Testing

See ufs-community/ufs-weather-model#2183

Associated PRs:

NOAA-GFDL/GFDL_atmos_cubed_sphere#330
#183
NOAA-EMC/fv3atm#798
ufs-community/ufs-weather-model#2183

[grantfirl]

@climbfuji I'd like to keep these in the repo since they can be useful. You've already done the work, so why not?

[climbfuji]

@climbfuji I'd like to keep these in the repo since they can be useful. You've already done the work, so why not?

Fine with me. We should have a regression test though to make sure they are still working

[climbfuji]

This PR is now ready for review

[climbfuji]

@DusanJovic-NOAA @dustinswales @grantfirl I just pushed commit afa2bc0 (and corresponding submodule pointer updates all the way up to ufs-weather-model).

I was able to build a spack-stack environment "somewhat similar" to that on WCOSS2 on S4 using [email protected]. WIth that environment, I ran into issues (segfaults, memory corruption) in clm_lake.f90 around the lakeini routine. That's probably the same part of the code that the WCOSS2 runs had problems with.

With the changes I made in commit afa2bc0, the runs went through on S4 (with the -check nopointer flag removed). Could you give this a try, please?

[FernandoAndrade-NOAA]

Testing on 2183 has completed successfully, please continue with the merge process.

[zach1221]

Adding @grantfirl . Grant, are you able to merge for us?