Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit alpha_fd coefficient to TOFD in drag_suite.F90 #210

Closed

Conversation

mdtoyNOAA
Copy link
Collaborator

Description

Added explicit 'alpha_fd' coefficient to drag_suite.F90 which corresponds directly to 'alpha' coefficient in Beljaars et al. (QJRMS, 2004), which by default is 12.0. The coefficient will be a runtime namelist option, and can control the strength of the turbulent orographic form drag (TOFD).
Note that the runtime results are bit-for-bit identical to those of the previous version unless a value other than alpha_fd = 12.0 in the namelist.
Regression tests have been performed on Hera with the Intel and Gnu compilers. The tests involving ugwpv1 all passed for both intel and gnu compilers, however, some of the other gnu tests failed. These tests also failed with the previous commit, so failures don't appear to have to do with the code changes in this PR.

Issues

This PR addresses ccpp-physics Issue #208.

[alpha_fd]
standard_name = alpha_coefficient_for_turbulent_orographic_form_drag
long_name = alpha coefficient for Beljaars et al turbulent orographic form drag
units = none
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: units should be 1 here. See https://github.com/ESCOMP/CCPPStandardNames/blob/main/StandardNamesRules.rst.

Please make the same change everywhere else this variable is used in ccpp/physics and fv3atm.

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine once small metadata change is completed.

@mdtoyNOAA
Copy link
Collaborator Author

Looks fine once small metadata change is completed.

Thank you. @grantfirl This draft PR is being folded in to PR #207, but I see you've made the same comment in that thread, so all should be well.

Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, just the metadata change pointed out by Grant.

@grantfirl
Copy link
Collaborator

This is to be combined into #207

@grantfirl grantfirl closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants