Land surface upgrades for HR4 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with ufs/dev
HelinWei-NOAA
requested review from
grantfirl,
Qingfu-Liu,
dustinswales,
barlage and
cenlinhe
as code owners
This was referenced Jul 2, 2024
|
@barlage @cenlinhe @dustinswales @grantfirl We'd appreciate it if you can review this PR. We'd like to get this PR committed to start GFS HR4 experiments at the earliest time possible. |
barlage
approved these changes
Jul 16, 2024
| do is = isnow,0 | ||
| tsnoxy(ix,is) = tgxy(ix) | ||
| ! tsnoxy(ix,is) = tgxy(ix) | ||
| ! tsnoxy(ix,is) = tgxy(ix) + (( sum(dzsno(isnow:is)) -0.5*dzsno(is) )/snd)*(tgxy(ix)-stc(ix,1)) |
There was a problem hiding this comment.
probably best to clean this up by removing all the comments
cenlinhe
reviewed
Jul 16, 2024
| @@ -1989,7 +1989,7 @@ subroutine energy (parameters,ice ,vegtyp ,ist ,nsnow ,nsoil , & !in | |||
|
|
|||
| real (kind=kind_phys), parameter :: mpe = 1.e-6 | |||
| real (kind=kind_phys), parameter :: psiwlt = -150. !metric potential for wilting point (m) | |||
| real (kind=kind_phys), parameter :: z0 = 0.002 ! bare-soil roughness length (m) (i.e., under the canopy) | |||
| real (kind=kind_phys), parameter :: z0 = 0.015 ! bare-soil roughness length (m) (i.e., under the canopy) | |||
There was a problem hiding this comment.
where does "0.015" come from? Is it tuned? I did not find this value in the Noah-MP.
There was a problem hiding this comment.
it is tuned based on wind speed bias over bare soil and vegetated areas with low vegetation fraction
cenlinhe
approved these changes
Jul 16, 2024
|
@grantfirl @dustinswales any chance for final reviews? |
grantfirl
approved these changes
Jul 18, 2024
|
Testing for #2354 has completed successfully, please continue with the merge process. @grantfirl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address some concerns from HR3 especially the surface cold biases we have finalized some land surface upgrades after carrying out extensive tests and evaluation.