Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop:] Updated UFS_UTILS, ufs-weather-model hashes; use of new sfc_data.nc format (v2) for the FV3atm #1199

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

natalie-perlin
Copy link
Collaborator

DESCRIPTION OF CHANGES:

  • Updated UFS_UTILS and ufs-weather-model hashes to a recent develop
    • use new format for the surface data, sfc_data.nc (V2), to prepare initial conditions for the FV3atm. The new format includes two dimensions for a vertical coordinate:
      • zaxis_1 for soil levels (i.e., 4 or 9);
      • zaxis_2 for ice levels (2 ). This is hard-coded at the moment, in ./UFS_UTILS/sorc/chgres_cube.fd/write_data.F90. Chgres_cube prepares data for coldstart.
        In SRW, kice is set to 9 for RUC_LSM and a restart (not COLDSTART).
  • Use updated topography and landcover data for make_orog task from the netcdf files, instead of older binary files.
    ${FIXorg}/topography.antarctica.ramp.30s.nc
    ${FIXorg}/landcover.umd.30s.nc
    ${FIXorg}/topography.gmted2010.30s.nc

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              18.44
(*)grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20250  DEAD                   3.41
(*)grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  DEAD                   3.04
(**)grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025021  DEAD                  12.93
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20250212120  COMPLETE              34.20
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2025021212075  COMPLETE              81.57
------------------------------------------------------------------------------------------------

(*) - get errors in make_ics, make_lbcs:

 - FATAL ERROR: UNRECOGNIZED INPUT DATA TYPE.
 - IOSTAT IS:   

(**) - cold start vertical coordinate kice=2, need kice=9 for RUC_LSM, yet to find an approach to reconcile

  • derecho.intel
  • gaea.intel
  • gaea-c6.intel
  • hera.gnu
  • hera.intel
  • hercules.intel
  • jet.intel
  • orion.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

Natalie Perlin added 2 commits February 13, 2025 07:39
… options when used for ICS/LBCS, use kice default for coldstart
@MichaelLueken
Copy link
Collaborator

@natalie-perlin -

I was able to get the grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 and grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot tests to pass on Orion using the current HEAD of UFS_UTILS by adding:

"-DCHGRES_ALL=ON"

to sorc/CMakeLists.txt under list(APPEND UFS_UTILS_ARGS:

# Build UFS utilities
if(BUILD_UFS_UTILS)
  list(APPEND TARGET_LIST UFS_UTILS)
  list(APPEND UFS_UTILS_ARGS
    "-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}"
    "-DCMAKE_INSTALL_BINDIR=${CMAKE_INSTALL_BINDIR}"
    "-DBUILD_TESTING=OFF"
    "-DCHGRES_ALL=ON"
  )
----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              18.11
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20250  COMPLETE              13.17
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              44.00
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2025021  DEAD                  11.74
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20250213083  COMPLETE              34.26
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2025021308354  COMPLETE              81.05
----------------------------------------------------------------------------------------------------
Total                                                              DEAD                 202.33

In order to get the grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR test to pass, the two levels for tiice will need to be interpolated to nine levels, presumably in the weather model's fv3atm/io/fv3atm_sfc_io.F90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants