-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3-moment option for NSSL cloud microphysics #1924
Conversation
The addition of -mcmodel=medium to Intel.cmake was needed on jet to avoid a link error. I think this is because jet compiles for multiple targets, which increases the code size enough to not fit in the 'small' mcmodel. (No problem on hera) |
@MicroTed Is this ready to be out of draft? |
@grantfirl I suppose so, and the FV3 one, too. |
Hi, @MicroTed . I think we're ready to begin testing of this PR next. Can you please sync up your branch to resolve conflicts? |
@MicroTed can you sync up at the fv3atm level? Ihttps://github.com/NOAA-EMC/fv3atm/pull/702 |
@jkbk2004 I think everything should be up to date now. |
@jkbk2004 @BrianCurtis-NOAA beginning testing of this PR. |
@BrianCurtis-NOAA FYI, the cpld_bmark_p8_intel BL creation needed an increase in time limit for Gaea within default_vars.sh. A standalone test creation run for that case showed in the timestamp that it took around 36-37 minutes, a bit over the default of 30 I believe. |
The last commit for the cpld_bmark_p8 test on gaea showed
|
Just to be clear, this timeout was during the BL creation run for rt.sh. After the time limit increase, there was no issue and the current successful Gaea log for this PR shows around the same runtime at |
I don't understand. Were all baselines generated on RDHPCS or just the new ones listed in this PR ? |
On hera, I confirm that only nssl and wof cases change results. |
Right, just regional_wofs, rrfs_v1nssl, and rrfs_v1nssl_nohailnoccn baselines changed. |
I copied over the 20231024 baselines to 20231102 and did baselines for the nssl/wofs tests and a large percentage of my tests failed in comparison. I wanted to confirm in the process of creating baselines, that you copied over the old baselines to the new baselines and added the changed baselines. |
I will re-do my git clone and try once more. |
@BrianCurtis-NOAA yes, I copied existing from 20231024 over to 20231102, then created new ones for those three cases mentioned previously, added them to 20231102. Then finally ran the matching against 20231102. |
Thanks Zach, then it was probably me. Apologies for the delay. |
@BrianCurtis-NOAA acorn test underway? |
Regression testing is complete. I'll follow up on the ccpp-physics PR to begin the merging process. |
@MicroTed please revert .gitmodule url changes and update the submodule hash for fv3atm. |
@zach1221 Thanks! They should be updated now |
PR Author Checklist:
Description
Adds support for NSSL microphysics option of 3-moment rain, graupel, and hail (or just rain and graupel if the hail species is deactivated). This predicts the reflectivity moment (6th moment in diameter), which in turn predicts the shape parameter of the gamma function particle size distribution.
Linked Issues and Pull Requests
Associated UFSWM Issue to close
N/A
Subcomponent Pull Requests
PR for CCPP: ufs-community/ccpp-physics#110
PR for FV3 with added variables needed by CCPP: NOAA-EMC/fv3atm#702
Blocking Dependencies
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Tests affected by changes in this PR:
Yes, it will change regional_wofs, rrfs_v1nssl, and rrfs_v1nssl_nohailnoccn because of some changes to the NSSL microphysics scheme that is used with the tests. Failed tests (comparisons): regional_wofs, rrfs_v1nssl, rrfs_v1nssl_nohailnoccnLibraries
Code Managers Log
Testing Log: