MYNN-EDMF, MYNN surface layer, and Thompson AA updates (combines 1940) #1945
Conversation
…f the UFS/develop and some small changes to address reviewer's comments.
BrianCurtis-NOAA
added
the
Incomplete
|
@BrianCurtis-NOAA We found another trigger for this issue ufs-community/ccpp-physics#114 in ufs-community/ccpp-physics#120. We've narrowed down the exact line that causes a runtime (FPE exception) for the rrfs_v1beta_debug_intel test and it is only a proximate cause, not the ultimate cause, similar to how the problem showed up before, except now it is being triggered by a change in the PBL scheme instead of MP. I suppose that we have a choice to merge as-is (assuming that the rest of the code changes are approved and pass expected tests) or add a simple bugfix as proposed in ufs-community/ccpp-physics#114, just so the failing test will complete. Do you have a preference? Once this is figured out, the plan is to test ufs-community/ccpp-physics#120 and ufs-community/ccpp-physics#116 separately to make sure that the appropriate tests are failing in each, then combine them for the queue. |
|
@grantfirl If there's no priority for this PR (I can't recall if it was), then I see no problem adding a bugfix here. The |
|
Any tests that use MYNN EDMF PBL, MYNN SFC, or Thompson MP should change results. The following RTs are expected to fail due to changed BL: |
|
After merging in #1940, all tests using RUC LSM should also change results. There is significant overlap with the previous MYNN changes. 063 rap_control_intel failed in check_result |
|
I'm running full RTs on Hera for the combined PR now. I'll post results when it is finished. |
FernandoAndrade-NOAA
added
the
Baseline Updates
|
Combined PR RT log Expected failures: |
|
Thanks for posting results and a log file for Hera @grantfirl. We'd like to begin testing on this PR next, @joeolson42 could you please resync all your branches and resolve conflicts? |
@joeolson42 @FernandoAndrade-NOAA Branches are all synced up now and ready for testing. |
|
@joeolson42 I can't edit the PR description, so you might want to update the checkboxes that we're ready to go. It's probably not a big deal though since I pasted all the info in the comments. Also, maybe edit the PR title to mention updating RUC LSM. |
|
@grantfirl done. checkboxes updated. |
zach1221
added
the
Ready for Commit Queue
|
@zach1221 please remove the incomplete label if this PR is actually complete. |
|
Jenkins-ci ORTs passed |
FernandoAndrade-NOAA
removed
the
Incomplete
|
@FernandoAndrade-NOAA If this PR has been combined with another, please edit the title to indicate that. |
zach1221
changed the title
jkbk2004
requested review from
BrianCurtis-NOAA,
zach1221,
SadeghTabas-NOAA and
FernandoAndrade-NOAA
|
This PR is ready. Please, go ahead to review and approve. |
PR Author Checklist:
Description
The following PR consists of updates to 3 schemes and related modules:
Subcomponent Pull Requests
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Tests effected by changes in this PR:
Libraries
Code Managers Log
Testing Log: