Feature/gfdlmpv3

[dustinswales]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• Commit 'test_changes.list' from previous step

---

Description:

This PR contains host side changes to accommodate a new cloud microphysics parameterization in the physics.

For the physics refactoring, all of the configuration/namelist info is moved into a common module that is referenced by both MP versions and a shared fv_sat_adj.F90. There are default values for the scheme configurations defined within this module, and overwritten by the namelist, if provided. Both the v1 and v3 rely on some of the same parameters, but with different default values. This is handled by introducing a pre-processor directive into the new configuration module.

Commit Message:

* UFSWM - GFDL Microphysics Version 3

Priority:

• Normal.

Git Tracking

• None

Sub component Pull Requests:

• FV3: NOAA-EMC/fv3atm#823
  • ccpp-physics: ufs-community/ccpp-physics#195

UFSWM Blocking Dependencies:

• None

---

Changes

• PR Adds New Tests/Baselines (GFDLMPv3 Regression tests for HAFS_regional_atm and control_iovr4).
• Logs on Hera: /scratch1/BMC/gmtb/Dustin.Swales/UFS/Ruyiu/ufs-weather-model/tests

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[jkbk2004]

@dustinswales can you sync up branch? we can start working on this pr. also, we are considering to combine in #2621 to this pr.

[dustinswales]

@dustinswales can you sync up branch? we can start working on this pr. also, we are considering to combine in #2621 to this pr.

Done. Do you want me to pull in https://github.com/JessicaMeixner-NOAA/ufs-weather-model/tree/WW3_nochangesync?

[jkbk2004]

@dustinswales can you sync up branch? we can start working on this pr. also, we are considering to combine in #2621 to this pr.

Done. Do you want me to pull in https://github.com/JessicaMeixner-NOAA/ufs-weather-model/tree/WW3_nochangesync?

@dustinswales Yes, please go ahead to pull in pull in https://github.com/JessicaMeixner-NOAA/ufs-weather-model/tree/WW3_nochangesync

[dustinswales]

@dustinswales can you sync up branch? we can start working on this pr. also, we are considering to combine in #2621 to this pr.

Done. Do you want me to pull in https://github.com/JessicaMeixner-NOAA/ufs-weather-model/tree/WW3_nochangesync?

@dustinswales Yes, please go ahead to pull in pull in https://github.com/JessicaMeixner-NOAA/ufs-weather-model/tree/WW3_nochangesync

Done.

[jkbk2004]

@dustinswales some update is needed at physics level: /glade/derecho/scratch/jongkim/FV3_RT/rt_23671/compile_atm_debug_dyn32_intel/err

/glade/derecho/scratch/jongkim/UFS-RT/rt-2503/FV3/ccpp/physics/physics/MP/Morrison_Gettelman/m_micro.F90(1935): error #6401: The attribut\
es of this name conflict with those made accessible by a USE statement.   [RHOI]
       real(kind=kind_phys), intent(out) :: rhoi(pcols,0:pver)
--------------------------------------------^

[dustinswales]

@jkbk2004 Sorry, a bug that snuck in during the review process, which was after I ran the full RTs.

[jkbk2004]

@dustinswales I see some more failures:

  328 |        rhow  = 1000._r8
      |       1
Error: Named constant 'rhow' in variable definition context (assignment) at (1)
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/build.make:1830: FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/physics/MP/Morrison_Gettelman/cldwat2m_micro.F.o] Error 1

While this gets updated, we will let #2487 and #2625 move first.

[dustinswales]

@jkbk2004 I reran the full set of RTs and everything passes except for these two cases:
/scratch1/BMC/gmtb/Dustin.Swales/stmp2/Dustin.Swales/FV3_RT/rt_2936302/cpld_dcp_gefs_intel/err
/scratch1/BMC/gmtb/Dustin.Swales/stmp2/Dustin.Swales/FV3_RT/rt_2936302/cpld_control_gefs_intel/err
@JessicaMeixner-NOAA Is there anything you could think of relating to WW3 that might be causing this?

[DeniseWorthen]

@dustinswales You error message (EXTCDE MPI_ABORT, IEXIT= 11) indicates that most likely you're not using the correct mod_def file for WW3. Although I'm not sure why that would be, assuming there was no issue w/ the input-data directory.

[dustinswales]

@dustinswales You error message (EXTCDE MPI_ABORT, IEXIT= 11) indicates that most likely you're not using the correct mod_def file for WW3. Although I'm not sure why that would be, assuming there was no issue w/ the input-data directory.

@DeniseWorthen Thanks.
Looking at the OG PR, I see there is an input file change, so maybe that's it?

[DeniseWorthen]

The current UWM is using

ufs-weather-model/tests/rt.sh

Line 1019 in 6cb9e1d

INPUTDATA_ROOT_WW3=${INPUTDATA_ROOT}/WW3_input_data_20250212

but for some reason, in your run log I see

export INPUTDATA_ROOT_WW3=/scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20240501/WW3_input_data_20250225

[DeniseWorthen]

I see, I think the PR that got pulled in needs the updated WW3 directory... (wasn't sure what 'og pr' was)

[dustinswales]

@DeniseWorthen OG is shorthand for the way too verbose ORG.
Looking at the conversation, it seems this failure is expected.

[DeniseWorthen]

@dustinswales I think Jessica's original PR (2621) should have no baseline changes though, when using the new input.

[jkbk2004]

@dustinswales We can let #2621 go first maybe by Wednesday. I will double check input file and test on both hera and hercules.

[JessicaMeixner-NOAA]

I have returned from leave, please let me know if anything is needed from me for this PR.