added reset password page #217
Conversation
Wan-Weng
commented
Feb 12, 2025
Wan-Weng
commented
- Issue Reset new password page #214
- Created a reset password page with a similar design to the login page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Hi Wan! Here are some small changes to make on ur PR:
- I see some styling differences between ur component and the login/signup form (blue shadow color and sizing and spacing)
- Email icon is off centered.
Your forgot password component:
Current Log in component:
src/client/routes/password.tsx
Outdated
|
|
||
| const Password = () => { | ||
| const { | ||
| formState: { errors }, |
There was a problem hiding this comment.
You should add isSubmitting to the form / button so only clickable if not submitted
src/client/routes/password.tsx
Outdated
| "hover:bg-saseBlueLight hover:text-white", | ||
| errors.email && "cursor-not-allowed opacity-50", | ||
| )} | ||
| disabled={!!errors.email} |
There was a problem hiding this comment.
This can be set to isSubmitting
|
Hi Wan! I know that u said u were busy this week but for creating your reset password page, you can call AuthForm.tsx like the login.tsx and signup.tsx so the styling can be applied in the same way (look at login.tsx and signup.tsx to see what I mean). This would require you to edit the AuthForm.tsx as well. Let me know with any questions. |
|
looks good to me, nice job Wan! |
