Contact form #221
Merged
Contact form #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Make sure to request review when you're ready to merge |
ssihala
reviewed
Feb 14, 2025
src/server/api/contact.ts
Outdated
| html: formHTML, | ||
| }), | ||
| }); | ||
| console.log(resp.status); |
There was a problem hiding this comment.
Remove/comment out the console logs
ssihala
reviewed
Feb 14, 2025
armans-code
reviewed
Feb 14, 2025
| body: JSON.stringify(data), | ||
| }); | ||
| if (!resp.ok) { | ||
| throw new Error(`Response status: ${resp.status}"`); |
There was a problem hiding this comment.
would be nice if we had a toast for errors but I guess it's not too necessary if our API endpoint is reliable
|
Do we also want to email the form submitter a confirmation email? Maybe it's not necessary, just a random thought :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality to contact form on 'About' page of website