Events slide component implementation #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks good to me! Thanks mia. |
TheRickyZhang
requested changes
Feb 14, 2025
There was a problem hiding this comment.
The slides load kind of slow, so you can use prefetch or preload to have them ready quicker
There's also an x in the middle of the slides. Maybe some accidental or incorrect model nesting
There was a problem hiding this comment.
Probably use slidesData instead of imageData. Could also have an option to search through captions (should be called eventName?), but that can be implemented later.
I thought it would give a warning but seo is not used so it should be deleted/commented
TheRickyZhang
added a commit
that referenced
this pull request
Feb 25, 2025
This reverts commit 1a5b579.
TheRickyZhang
added a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #199 and #142