Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Navigation Component #234

Merged
merged 19 commits into from
Feb 19, 2025
Merged

Mobile Navigation Component #234

merged 19 commits into from
Feb 19, 2025

Conversation

T-Joseph-Kim
Copy link
Collaborator

@T-Joseph-Kim T-Joseph-Kim commented Feb 19, 2025

Issue #226 [Mobile Navigation Component]:

  • Matches new figma mobile design.
  • Gradient background for children navigation items (to black in dark mode, to white in light mode).
  • Added smooth animations for the menu and submenus.

image
image

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uf-sase-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 8:28pm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI feels a bit unintuitive, where instead of contracting the menu, clicking it takes you to that page, which people might not recognize is a page. Dropdown is a bit too wide, and hamburger icon should be set relative to right side as well

lazysince87 and others added 8 commits February 19, 2025 15:22
changed sign up input text's preview text to be username or email.
* Fix blog validations on client

* Remove last_update_date

* Make b:push run first

---------

Co-authored-by: Ricky Zhang <[email protected]>
Co-authored-by: UF SASE Webmaster <[email protected]>
@TheRickyZhang TheRickyZhang merged commit a75ed22 into main Feb 19, 2025
6 checks passed
@TheRickyZhang TheRickyZhang deleted the mobile-nav branch February 19, 2025 20:29
TheRickyZhang added a commit that referenced this pull request Feb 19, 2025
* mostly done

need to figure out gradient length fix and add white gradient when white navgiation bar

* temp fix to about

* white gradient

* login button styling

* gradient styling fixes

* styling

* cn reformatting

* text too big :(

* hover scale styling

* Close mobile menu on outside click

* delete unused routes

* fixed signup and auth error handling

* fixed formatting

* responses fixed

* update authform

changed sign up input text's preview text to be username or email.

* Fix blog validations on client (#241)

Yippee

* Fix blogs validation part 2, remove last_update_date (#242)

* Fix blog validations on client

* Remove last_update_date

* Make b:push run first

---------

Co-authored-by: Ricky Zhang <[email protected]>
Co-authored-by: UF SASE Webmaster <[email protected]>

* wrote better program description

* trivial change

---------

Co-authored-by: Ricky Zhang <[email protected]>
Co-authored-by: Thuy Le <[email protected]>
Co-authored-by: redtinypoop <[email protected]>
Co-authored-by: Sihala Senevirathne <[email protected]>
Co-authored-by: UF SASE Webmaster <[email protected]>
Co-authored-by: Elliot Liu <[email protected]>
TheRickyZhang added a commit that referenced this pull request Feb 19, 2025
* fix: remove "CHANGE!!!!!" text from sponsor card

* fix: move button below text on sponsor card

* update authform

changed sign up input text's preview text to be username or email.

* Fix blog validations on client (#241)

Yippee

* Fix blogs validation part 2, remove last_update_date (#242)

* Fix blog validations on client

* Remove last_update_date

* Make b:push run first

---------

Co-authored-by: Ricky Zhang <[email protected]>
Co-authored-by: UF SASE Webmaster <[email protected]>

* wrote better program description

* Mobile Navigation Component (#234)

* mostly done

need to figure out gradient length fix and add white gradient when white navgiation bar

* temp fix to about

* white gradient

* login button styling

* gradient styling fixes

* styling

* cn reformatting

* text too big :(

* hover scale styling

* Close mobile menu on outside click

* delete unused routes

* fixed signup and auth error handling

* fixed formatting

* responses fixed

* update authform

changed sign up input text's preview text to be username or email.

* Fix blog validations on client (#241)

Yippee

* Fix blogs validation part 2, remove last_update_date (#242)

* Fix blog validations on client

* Remove last_update_date

* Make b:push run first

---------

Co-authored-by: Ricky Zhang <[email protected]>
Co-authored-by: UF SASE Webmaster <[email protected]>

* wrote better program description

* trivial change

---------

Co-authored-by: Ricky Zhang <[email protected]>
Co-authored-by: Thuy Le <[email protected]>
Co-authored-by: redtinypoop <[email protected]>
Co-authored-by: Sihala Senevirathne <[email protected]>
Co-authored-by: UF SASE Webmaster <[email protected]>
Co-authored-by: Elliot Liu <[email protected]>

---------

Co-authored-by: redtinypoop <[email protected]>
Co-authored-by: Sihala Senevirathne <[email protected]>
Co-authored-by: Ricky Zhang <[email protected]>
Co-authored-by: UF SASE Webmaster <[email protected]>
Co-authored-by: Elliot Liu <[email protected]>
Co-authored-by: Taebok Joseph Kim <[email protected]>
Co-authored-by: Thuy Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants