update #251
update #251
Conversation
luca-c-coll
commented
Feb 23, 2025
luca-c-coll
commented
- About Page (Mobile Version) [FE] #225
- Modified the about page's title format "About" for consistency.
- Reduced SASE Star Logo and modified buttons for About section.
- Created a component specifically for Mission Statement section on mobile.
- Adjusted the History Section to have a Read More/Read Less link for better readability.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return ( | ||
| <section className={cn("mb-8")}> | ||
| <div className={cn("max-w-5xl")}> | ||
| <p className={cn("mb-4 text-lg text-gray-800")}> | ||
| <span className={cn("font-semibold")}>Since being founded during the summer of 2010,</span> the University of Florida chapter has had an | ||
| abundant effort put forth for the development of our members. |
There was a problem hiding this comment.
Usage of cn here (and across all other changes) is redundant if we're not using its conditional styling capabilities (just do className = {...})
| abundant effort put forth for the development of our members. | ||
| </p> | ||
| <p className={cn("mb-4 text-lg text-gray-800")}> | ||
| This development is centered on <span className={cn("font-semibold")}>five core values</span> of our mission statement:{" "} |
There was a problem hiding this comment.
Why not use < strong > instead of wrapping in font-sermibold?
| useEffect(() => { | ||
| const handleResize = () => setIsMobile(window.innerWidth < 1024); | ||
| handleResize(); | ||
| window.addEventListener("resize", handleResize); | ||
| return () => window.removeEventListener("resize", handleResize); | ||
| }, []); |
There was a problem hiding this comment.
This should be in a hook to not redeclare for every file (check if one already exists)
|
|
||
| {/* Read More / Read Less Toggle */} | ||
| {!isExpanded && ( | ||
| <div className={cn("flex w-fit cursor-pointer items-center text-blue-600 hover:underline")} onClick={() => setIsExpanded(true)}> |
There was a problem hiding this comment.
Read More option should only appear when the window "isMobile" but it currently shows up always.
| {!isExpanded && ( | ||
| <div className={cn("flex w-fit cursor-pointer items-center text-blue-600 hover:underline")} onClick={() => setIsExpanded(true)}> | ||
| <span>Read more</span> | ||
| {!isMobile && <FaChevronDown className={cn("ml-1 h-4 w-4")} />} |
There was a problem hiding this comment.
The chevron disappears when the window "isMobile"
There was a problem hiding this comment.
This is spot on, good job Luca!
|
Please make sure that it is updated with main; try pulling from main and resolving merge conflicts yourself. Ask for help if needed. |
|
|
|
Oh if you want to merge the -new version change the base or make a new pr |
|
Sorry about all the conflicts, I will try to get that fixed. |
|
I checked the status of the branch with git status but I am not sure what is going on with the '66 commits behind'. |
|
I just checked it from here: https://github.com/ufsasewebmaster/UF-SASE-Website/tree/about-page-mobile |
|
I see now, thank you! How do I pull all 66 commits to update the branch? |
