Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mask_embed for latest changes? #59

Merged
merged 13 commits into from
Aug 14, 2024
Merged

Fixing mask_embed for latest changes? #59

merged 13 commits into from
Aug 14, 2024

Conversation

ctr26
Copy link
Collaborator

@ctr26 ctr26 commented Aug 12, 2024

@afoix

  • dropping batch_idx
  • added shape tests for sanity checking
  • class MaskEmbedSupervised(AutoEncoderSupervised, MaskEmbed):
    pass
  • Adding prediction tests
    This is not implemented nor present in the new test

@ctr26
Copy link
Collaborator Author

ctr26 commented Aug 13, 2024

@afoix I added a MaskEmbed mixin class, this is used to overwrite the two AutoEncoder functions (batch_to_tensor and loss_function) that are needed

@ctr26 ctr26 requested a review from afoix August 13, 2024 15:05
bioimage_embed/shapes/lightning.py Outdated Show resolved Hide resolved
bioimage_embed/shapes/lightning.py Outdated Show resolved Hide resolved
@afoix
Copy link
Collaborator

afoix commented Aug 13, 2024

It's also probably worth exporting the new MaskEmbedSupervised class in bioimage_embed/shapes/__init__.py.

@ctr26
Copy link
Collaborator Author

ctr26 commented Aug 14, 2024

  • Fixed the mixin
  • Testing for 1 - many classes
  • Reorganised frobenius_norm logic

@ctr26 ctr26 requested a review from afoix August 14, 2024 12:11
@ctr26 ctr26 merged commit 66a174f into master Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants