Binderising #5
Binderising #5
Conversation
|
@sohmandal, the binder bit seems to be working, the github testing less so but github actions don't have cuda support sooo |
|
Github actions actually run out of memory before testing anyway so I'll remove |
|
@afoix can you give this a look to see if it's safe to merge? |
| @@ -52,7 +52,7 @@ def build_extension(self, ext): | |||
| common_src = ['stardist/lib/utils.cpp'] | |||
|
|
|||
| setup( | |||
| name='stardist', | |||
| name='splinedist', | |||
| version=__version__, | |||
| description='StarDist', | |||
There was a problem hiding this comment.
@ctr26 sorry to be picky, could you please change the description too? It says also StarDist 😄
| # - run: python3 -m pip install jupyter-repo2docker | ||
| # - run: repo2docker --no-run --image-name spline_contour:latest --user-id=1001 --user-name=1001 . | ||
| # - run: docker run spline_contour:latest pytest --nbmake data.ipynb training.ipynb prediction.ipynb |
There was a problem hiding this comment.
If the we do not need this commands, I'd suggest to remove it. Unless, there is a reason to leave it.
| repo2docker.build: | ||
| repo2docker --no-run --image-name spline_contour . | ||
|
|
||
| # repo2docker.tests: |
There was a problem hiding this comment.
Same with this, I'd remove the commented commands :)
| - libopencv | ||
| - py-opencv | ||
| - ipython | ||
| # - jupyter |
There was a problem hiding this comment.
If we don't need Jupyter we can remove it
| # - cxx-compilern | ||
| # - gcc_linux-64 | ||
| # - nvcc_linux-64 | ||
| # - nccl | ||
| # - nvidia-ml |
There was a problem hiding this comment.
Same with all the compiler stuff and the nvidia pluggins.
Don't accept yet still checking it's right