Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple issues that lead to subtle timing bugs in useThrottle. For an example, see this codesandbox and notice how throttledValue (current implementation) updates kind of choppily and drops some values, whereas throttledValue2 (includes this fix) works as you'd expect.
First fix is that the
now
variable insidesetTimeout
does not actually refer to the current time, it refers to the timesetTimeout
was called. That meanslastUpdated.current
will be incorrect (too low) for the next update. Instead we should get a newDate.now()
value.Second fix is that the
setTimeout
is currently delayed by the full value ofinterval
, even if there is only like a millisecond left until the interval elapses. Fix is to instead delay it byinterval
minus the time since the last update.