Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Commit

Permalink
ED 967 all button non javascript (#9)
Browse files Browse the repository at this point in the history 
* ED-967: make the 'all' button on the shared header work without javascript

* Revert "ED-967: make the 'all' button on the shared header work without javascript"

This reverts commit dba7696.

* Add: Non-JS view support for navigation
  • Loading branch information
@stevenburnell-dit
stevenburnell-dit authored and Richard Tier committed Feb 8, 2017
1 parent f051da6 commit af37847
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ node_modules/
assets/test/unit/coverage/

# Whoosh search index
iwhoosh_index*
whoosh_index*

# Caches
.sass-cache
7 changes: 7 additions & 0 deletions public/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@
<!-- Place favicon.ico in the root directory -->

<link rel="stylesheet" href="css/main.css">
<noscript>
<style>
.navigation-toggle {
display: block;
}
</style>
</noscript>
</head>
<body>
<header role="banner">
Expand Down

1 comment on commit af37847

@dahfool
Copy link
Contributor

@dahfool dahfool commented on af37847 Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richtier like the solution, it would be better to move the styling outside the markup . e.g

    <noscript>
      <link href="stylesheets/no-js.css"" rel="stylesheet" media="screen">
    </noscript>

In case we have more style for no js. I think its good to separate markup, style and functionality.

Please sign in to comment.